Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][Typography] Update variantMapping default value formatting in JSDoc #44801

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MBCSdatalogger
Copy link

Error occurred in scoping due to line 77 @default '{'

Error occurred in scoping due to line 77  @default '{'

Signed-off-by: MBCSdatalogger <[email protected]>
@mui-bot
Copy link

mui-bot commented Dec 18, 2024

Netlify deploy preview

https://deploy-preview-44801--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 6de2ff7

Copy link
Contributor

@sai6855 sai6855 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBCSdatalogger run pnpm prettier and commit changes, this change will make CI green

@zannager zannager added the component: Typography The React component. label Dec 19, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title Update Typography.d.ts [docs] Update variantMapping default value formatting in JSDoc Dec 24, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [docs] Update variantMapping default value formatting in JSDoc [docs][Typography] Update variantMapping default value formatting in JSDoc Dec 24, 2024
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBCSdatalogger What is the motive of the PR? I assume it is to fix the default value formatting.

Before:

Screenshot (40)

After:

Screenshot (42)

@aarongarciah aarongarciah added the docs Improvements or additions to the documentation label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Typography The React component. docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants